From c02268d56eed81c2e015a76e67f0b4eea609e717 Mon Sep 17 00:00:00 2001 From: Grant Lanham Date: Sat, 19 Oct 2024 18:37:29 -0400 Subject: [PATCH] [fix] remove unknown_params from preferences --- searx/preferences.py | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/searx/preferences.py b/searx/preferences.py index c63ed904e..c1abd290e 100644 --- a/searx/preferences.py +++ b/searx/preferences.py @@ -479,7 +479,6 @@ class Preferences: self.plugins = PluginsSetting('plugins', plugins=plugins) self.tokens = SetSetting('tokens') self.client = client or ClientPref() - self.unknown_params: Dict[str, str] = {} def get_as_url_params(self): """Return preferences as URL parameters""" @@ -523,10 +522,6 @@ class Preferences: self.plugins.parse_cookie(input_data.get('disabled_plugins', ''), input_data.get('enabled_plugins', '')) elif user_setting_name == 'tokens': self.tokens.parse(user_setting) - elif not any( - user_setting_name.startswith(x) for x in ['enabled_', 'disabled_', 'engine_', 'category_', 'plugin_'] - ): - self.unknown_params[user_setting_name] = user_setting def parse_form(self, input_data: Dict[str, str]): """Parse formular (````) data from a ``flask.request.form``""" @@ -551,8 +546,7 @@ class Preferences: disabled_plugins.append(user_setting_name) elif user_setting_name == 'tokens': self.tokens.parse_form(user_setting) - else: - self.unknown_params[user_setting_name] = user_setting + self.key_value_settings['categories'].parse_form(enabled_categories) self.engines.parse_form(disabled_engines) self.plugins.parse_form(disabled_plugins) @@ -563,8 +557,6 @@ class Preferences: ret_val = None if user_setting_name in self.key_value_settings: ret_val = self.key_value_settings[user_setting_name].get_value() - if user_setting_name in self.unknown_params: - ret_val = self.unknown_params[user_setting_name] return ret_val def save(self, resp: flask.Response): @@ -577,8 +569,6 @@ class Preferences: self.engines.save(resp) self.plugins.save(resp) self.tokens.save('tokens', resp) - for k, v in self.unknown_params.items(): - resp.set_cookie(k, v, max_age=COOKIE_MAX_AGE) return resp def validate_token(self, engine):